Skip to content

Conversation

@drdavella
Copy link
Member

Overview

Fixes a relatively small bug related to parsing empty sonar issues files

Description

  • This problem was already handled safely but I think it's best to clarify/simplify the logic here
  • As far as I can tell, this would only occur with an empty and/or malformed Sonar issues input
  • Also cleaned up a few noisy deprecation warnings

from enum import Enum
from functools import cached_property
from importlib.abc import Traversable
from importlib.resources.abc import Traversable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix deprecation warning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it looks like we need to wait until we drop 3.10 support for this one (but we can do that pretty much any time we want).


class Config:
frozen = True
model_config = ConfigDict(frozen=True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix deprecation warning

@drdavella drdavella force-pushed the fix-sonar-issues-and-hotspots branch from 7ad013d to 8b9de7b Compare January 2, 2025 14:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Contributor

@nahsra nahsra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drdavella drdavella added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 7b2d930 Jan 2, 2025
15 checks passed
@drdavella drdavella deleted the fix-sonar-issues-and-hotspots branch January 2, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants