Skip to content

Improve performance of ObjectSelectionTree #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Birdy2014 merged 2 commits into from
Mar 12, 2025
Merged

Improve performance of ObjectSelectionTree #90

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0202019
Prevent redundant calls to compute_transforms in ObjectSelectionTree
Birdy2014 Mar 11, 2025
a6fc8c3
Set TreeNode IDs in a more efficient way in ObjectSelectionTree
Birdy2014 Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ui/ObjectSelectionTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ void ObjectSelectionTree::traverse_nodes(InstancedNode& root)
if (auto payload = ImGui::AcceptDragDropPayload("node")) {
auto node_to_instantiate = *static_cast<Node const**>(payload->Data);
child->children.push_back(instantiate_and_rename_node(*node_to_instantiate));
project->scene->compute_transforms();
}

// Drop InstancedNode onto TreeNode -> move to children
Expand All @@ -79,9 +80,8 @@ void ObjectSelectionTree::traverse_nodes(InstancedNode& root)
auto source_node = std::move(*source_iterator);
instancednode_payload.source_vector.erase(source_iterator);
child->children.push_back(std::move(source_node));
project->scene->compute_transforms();
}

project->scene->compute_transforms();
ImGui::EndDragDropTarget();
}

Expand All @@ -98,6 +98,7 @@ void ObjectSelectionTree::traverse_nodes(InstancedNode& root)
if (auto payload = ImGui::AcceptDragDropPayload("node")) {
auto node_to_instantiate = *static_cast<Node const**>(payload->Data);
root.children.insert(root.children.begin() + index, instantiate_and_rename_node(*node_to_instantiate));
project->scene->compute_transforms();
}

// Drop InstancedNode between TreeNodes -> move to parent node as sibling of current node
Expand All @@ -110,9 +111,8 @@ void ObjectSelectionTree::traverse_nodes(InstancedNode& root)
--index;
}
root.children.insert(root.children.begin() + index, std::move(source_node));
project->scene->compute_transforms();
}

project->scene->compute_transforms();
ImGui::EndDragDropTarget();
}
}
Expand Down