[Issue #1082] support message grouping and terminating in S3QS #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bianhq
requested changes
Dec 28, 2025
pixels-core/src/main/java/io/pixelsdb/pixels/core/PixelsWriterStreamImpl.java
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| package io.pixelsdb.pixels.storage.s3qs.exception; | |||
...ge/pixels-storage-s3qs/src/main/java/io/pixelsdb/pixels/storage/s3qs/PhysicalS3QSWriter.java
Outdated
Show resolved
Hide resolved
pixels-storage/pixels-storage-s3qs/src/main/java/io/pixelsdb/pixels/storage/s3qs/S3QS.java
Outdated
Show resolved
Hide resolved
pixels-storage/pixels-storage-s3qs/src/main/java/io/pixelsdb/pixels/storage/s3qs/S3QS.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,85 @@ | |||
| package io.pixelsdb.pixels.storage.s3qs; | |||
...torage/pixels-storage-s3qs/src/main/java/io/pixelsdb/pixels/storage/s3qs/S3QueueMessage.java
Outdated
Show resolved
Hide resolved
pixels-storage/pixels-storage-s3qs/src/main/java/io/pixelsdb/pixels/storage/s3qs/S3Queue.java
Outdated
Show resolved
Hide resolved
pixels-storage/pixels-storage-s3qs/src/test/java/io/pixelsdb/pixels/storage/s3qs/TestS3QS.java
Outdated
Show resolved
Hide resolved
bianhq
requested changes
Dec 31, 2025
pixels-core/src/main/java/io/pixelsdb/pixels/core/PixelsWriterImpl.java
Outdated
Show resolved
Hide resolved
pixels-core/src/main/java/io/pixelsdb/pixels/core/PixelsWriterImpl.java
Outdated
Show resolved
Hide resolved
| this.builderPhysicalWriter = PhysicalWriterUtil.newPhysicalWriter( | ||
| this.builderStorage, this.builderFilePath, this.builderBlockSize, this.builderReplication, | ||
| this.builderBlockPadding, this.builderOverwrite); | ||
| } catch (IOException e) { |
Contributor
There was a problem hiding this comment.
catch on a new line, { on a new line.
| LOGGER.error("Failed to create PhysicalWriter"); | ||
| throw new PixelsWriterException( | ||
| "Failed to create PixelsWriter due to error of creating PhysicalWriter", e); | ||
| try { |
| { | ||
| this.queue.push(this.pathStr); | ||
| } | ||
| }catch (IOException e){ |
| private long timestamp = System.currentTimeMillis(); | ||
| private String metadata = ""; | ||
|
|
||
| public S3QueueMessage() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1082
This PR is the first step to enable shuffle support in S3QS. S3QS can now support message passing between workers in different groups, as well as pipeline termination signals.
Key improvements:
Defined the message format provided by workers, enabling identification of worker IDs and partition numbers.
Since S3QS is used exclusively for shuffle tasks, it can serve as the task manager connecting the upstream and downstream of the shuffle, providing communication channels.