Skip to content

[Issue #1273] fix readFully in S3 storage #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianhq merged 1 commit into from
Jan 6, 2026
+15 −6
Merged

[Issue #1273] fix readFully in S3 storage #1274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions ...orage/pixels-storage-s3/src/main/java/io/pixelsdb/pixels/storage/s3/AbstractS3Reader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ public abstract class AbstractS3Reader implements PhysicalReader
* The implementations of most methods in this class are from its subclass PhysicalS3Reader.
*/

protected boolean enableAsync = false;
protected boolean useAsyncClient = false;
protected boolean enableAsync;
protected boolean useAsyncClient;
protected static final ExecutorService clientService;

static
Expand Down Expand Up @@ -125,7 +125,7 @@ protected String toRange(long start, int length)
}

@Override
public long getFileLength() throws IOException
public long getFileLength()
{
return length;
}
Expand Down Expand Up @@ -159,7 +159,8 @@ public ByteBuffer readFully(int len) throws IOException
this.numRequests++;
this.position += len;
return response.asByteBuffer();
} catch (Exception e)
}
catch (Exception e)
{
throw new IOException("Failed to read object.", e);
}
Expand All @@ -175,8 +176,16 @@ public void readFully(byte[] buffer) throws IOException
public void readFully(byte[] buffer, int off, int len) throws IOException
{
ByteBuffer byteBuffer = readFully(len);
// This is more efficient than byteBuffer.put(buffer, off, len).
System.arraycopy(byteBuffer.array(), byteBuffer.arrayOffset() + byteBuffer.position(), buffer, off, len);
if (byteBuffer.hasArray())
{
// This is more efficient than byteBuffer.get(buffer, off, len).
System.arraycopy(byteBuffer.array(), byteBuffer.arrayOffset() + byteBuffer.position(),
buffer, off, len);
}
else
{
byteBuffer.get(buffer, off, len);
}
}

/**
Expand Down