Open
Conversation
Contributor
Author
|
I am tempted to add passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have ran into some issues with the ColorMapFilter and alpha. I created a
reproduction (zip) that can be run locally and have provided screenshots of the demo below.
In general the filter did not properly handle the premultiplied nature of the textures and had some issues with still having the blue channel as
linearwhen set tonearest.I've also updated the documentation for the color map texture as well as added an example color map to the filter's folder.
There are two breaking changes in this PR: the keys in ColorMapFilter.uniform have changed, and the way the filter looks will be less "glitchy" (most obvious on the bottom image in the "Passthrough 4x4x4, nearest"-example).
Screenshots of different color maps that can be seen in the example code.
Passthrough 4x4x4, linear
Passthrough 4x4x4, nearest
Hue rotate 4x4x4, linear
Hue rotate 4x4x4, nearest
Passthrough 32x32x32, linear
Passthrough 32x32x32, nearest