Skip to content

Conversation

@pixincreate
Copy link
Owner

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • add more detectors
  • add more unit test coverage
  • make sure that multi-line check is done by going through the patterns prior to executions

Context

i felt like i need to broaden the detection. so added more patterns.

How did you test it?

ci check should pass

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate self-assigned this Feb 16, 2025
@pixincreate pixincreate added the enhancement New feature or request label Feb 16, 2025
@gitguardian
Copy link

gitguardian bot commented Feb 16, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15634623 Triggered Square Token cc93811 tests/integration_tests.rs View secret
15634624 Triggered RSA Private Key cc93811 tests/integration_tests.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@pixincreate pixincreate merged commit 118137b into main Feb 16, 2025
6 checks passed
@pixincreate pixincreate deleted the feat/more-detectors branch February 16, 2025 15:19
@pixincreate pixincreate mentioned this pull request Feb 16, 2025
pixincreate added a commit that referenced this pull request Feb 16, 2025
…pts-and-docs

* 'main' of github.com:pixincreate/KeyWatch:
  feat(detectors): add more detectors and increase unit test coverage (#4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants