refactor: enable an eslint rule, @typescript-eslint/strict-boolean-expressions#633
Open
refactor: enable an eslint rule, @typescript-eslint/strict-boolean-expressions#633
@typescript-eslint/strict-boolean-expressions#633Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel of #292
lintに危なげなboolean expressionsを起こってくれるルールを追加しました。
レビューの際は、以下のメリデメ吟味して良さそうか悪そうか判断いただければ幸いです。
pros
0の誤falsyがあり得るnumber | undefinedの使用を禁止してくれます""も同様cons
boolean | undefinedが怒られるのは若干うるさいか？boolean | undefinedの後ろに?? falseが付きました""の確認をさせられるのは少しうるさいです