DATAAPI-37: support custom endpoints#90
Merged
DominicWatson merged 4 commits intostablefrom Jun 24, 2025
Merged
Conversation
…r to support custom handlers as well
jjannek
commented
Feb 12, 2025
| var dataApiRoutes = dataApiConfigurationService.getDataApiRoutes(); | ||
| for( var apiRoute in dataApiRoutes ) { | ||
| if ( api == apiRoute && reFindNoCase( "^data\.v1", resource.handler ?: "" ) ) { | ||
| if ( api == apiRoute && reFindNoCase( regex, resource.handler ?: "" ) ) { |
Collaborator
Author
There was a problem hiding this comment.
The check on namespaced APIs is not necessarily required, because the resource handler differs anyway. I have just added it here to be consistent with the default API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently custom endpoints that are mixed into a data api only work on namespaced APIs, not on the default one (/data/v1). This is solved when explicitly checking for the full api handlers on rest request.
Examples:
/data/v1/entity/contact request will resolve to the handler data.v1.WholeEntity
/mycustomapi/v1/entity/contact request will also resolve to the handler data.v1.WholeEntity
/mycustomapi/v1/test/ will have a handler detected as mycustomapi.v1.test, therefore not being picked up by the Data API Service
But
/data/v1/test/ will have a handler detected as data.v1.test, being picked up by DataApiService and therefore leads to a 404