Take product name as query param to avoid conflicts and special chars like /

Author: piyush-jaiswal

app/routes.py

@@ -881,16 +881,16 @@ def delete_product(p_id):
         return "Error occured", 500
 
 
-@app.route('/product/<string:name>', methods=['GET'])
-def get_product_by_name(name):
+@app.route('/product', methods=['GET'])
+def get_product_by_name():
     """
     Get Product by Name
     ---
     tags:
         - Product
     description: Get a product by name.
     parameters:
-        - in: path
+        - in: query
           name: name
           required: true
           type: string
@@ -903,6 +903,10 @@ def get_product_by_name(name):
         500:
             description: Error occurred.
     """
+    name = request.args.get('name')
+    if not name:
+        abort(400, description="Missing required query parameter 'name'")
+
     product = Product.query.filter(Product.name == name).first()
     if product is None:
         abort(404)

tests/test_product.py

@@ -116,23 +116,29 @@ def test_delete_product(self, create_authenticated_headers, create_product):
         assert get_resp.status_code == 404
         self._verify_product_in_db("ToDelete", should_exist=False)
 
-    def test_get_product_by_name(self, create_product):
-        product_name = "Test Product With Spaces"
-        response = create_product(product_name, "A test product with spaces")
+    @pytest.mark.parametrize(
+        "name",
+        [
+            "Test Product With Spaces And / And @",
+            "Café",
+            "C++",
+            "20% off"
+        ]
+    )
+    def test_get_product_by_name(self, create_product, name):
+        response = create_product(name, "desc")
         assert response.status_code == 201
         data = response.get_json()
         p_id = data["id"]
 
-        encoded_name = quote(product_name)
-        get_resp = self.client.get(f"/product/{encoded_name}")
+        get_resp = self.client.get("/product", query_string={"name": name})
         assert get_resp.status_code == 200
         prod_data = get_resp.get_json()
         assert prod_data["id"] == p_id
-        assert prod_data["name"] == product_name
-        assert prod_data["description"] == "A test product with spaces"
+        assert prod_data["name"] == name
+        assert prod_data["description"] == "desc"
 
-        encoded_name = quote("Non Existent Product")
-        not_found_resp = self.client.get(f"/product/{encoded_name}")
+        not_found_resp = self.client.get("/product", query_string={"name": "Non existent product"})
         assert not_found_resp.status_code == 404
 
     @pytest.mark.parametrize(