-
Notifications
You must be signed in to change notification settings - Fork 1
Build production artifacts for production deployment #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflow for production deployment has been updated to add the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/deploy_production.yml (1)
34-36: Consider making the build step fully non-interactive and keep the CLI flags consistentAdding
--prodis correct; however,vercel buildcan still prompt for confirmation in certain edge-cases (e.g., project not yet linked locally). To keep the pipeline 100 % non-interactive and symmetric with the earlierpullstep, append--yes:- run: vercel build --prod --token=${{ secrets.VERCEL_TOKEN }} + run: vercel build --prod --yes --token=${{ secrets.VERCEL_TOKEN }}This guarantees the job never hangs on a prompt.
(Optional) You could also drop--token=…here and rely on theVERCEL_TOKENenv var already exposed in the shell, reducing noise and ensuring the secret never accidentally ends up in logs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/deploy_production.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy-preview
Summary by CodeRabbit