python: EPYTEST_* related checks
#747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurzam
requested changes
Jul 13, 2025
This was
linked to
issues
Jul 13, 2025
Add a check for `EPYTEST_*` variables being declared after calling
`distutils_enable_tests`, so they don't affect it. This catches only
global scope use, as it is valid to override them in function scope.
Since using `${var:=...}` assignment is also valid, hack a quick method
to handle them as well.
Closes: pkgcore#739
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Contributor
Author
|
Updated. |
thesamesam
reviewed
Jul 14, 2025
Member
thesamesam
left a comment
thesamesam
left a comment
There was a problem hiding this comment.
(Sorry, I didn't realise these comments were still pending and not submitted.)
| PythonAnyMismatchedDepHasVersionCheck, | ||
| PythonMissingSCMDependency, | ||
| ] | ||
| MisplacedEPyTestVar, |
Member
There was a problem hiding this comment.
Nit: not a fan of "PyTest`. I think the upstream style is "pytest" but they sometimes use "Pytest". I get it's awkward because of the "E" though.
Contributor
Author
There was a problem hiding this comment.
Yeah, mixed feelings about that too but it seems more consistent than "Epytest" or "EPytest".
Member
|
It looks good by the way. The comments are really just that rather than request for changes necessarily. |
Closes: pkgcore#740 Signed-off-by: Michał Górny <mgorny@gentoo.org>
arthurzam
approved these changes
Jul 15, 2025
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Add a check for `EPYTEST_*` variables being declared after calling
`distutils_enable_tests`, so they don't affect it. This catches only
global scope use, as it is valid to override them in function scope.
Since using `${var:=...}` assignment is also valid, hack a quick method
to handle them as well.
Closes: #739
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Part-of: #747
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EPYTEST_TIMEOUToverriding user value ([New Check]:EPYTEST_TIMEOUToverriding user value #740)EPYTEST_*variables ([New Check]:EPYTEST_*variables declared after callingdistutils_enable_tests#739)