fix RMG access to /usr/share/RMG
#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It works 🎉 |
|
libstdc++ uses __openat_2 in std::filesystem::recursive_directory_iterator, added it to pathmap 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is weird, the app does not contain the string
/usr/shareyet it is hardcoded to look into/usr/share/RMGPATH_MAPPING_HARDCODEDwas already needed to fix the access to/usr/lib/RMG, all this does it patch away/usr/libfor/tmp/XXXwhere XXX is 3 random characters, then theAppRunmakes a symlink there to thelibdir of the appimage and all good.The app instead contains a
/usr/libLwith that weirdLas the hardcoded string, so this can be patched without problem.For
/usr/shareit instead has/usr/shaLdafuck. So this cannot be patched manually.Thankfully we have another way of fixing the hardcoded path, that is using pathmap which is a library we preload instead of doing binary patching.
Funny enough it only works for
/usr/share/RMGit does not work for/usr/lib/RMGso we need to use BOTH methods here 😹Artifact for testing