Skip to content

set $VERSION variable #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psadi merged 2 commits into from
Jan 11, 2025
Merged

set $VERSION variable #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b72e163
set `$VERSION` variable
Samueru-sama Jan 11, 2025
76f16ac
release versioned appimages
Samueru-sama Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
with:
name: ghostty-appimage
retention-days: 7
path: /tmp/ghostty-build/Ghostty-x86_64.AppImage*
path: /tmp/ghostty-build/Ghostty-*-x86_64.AppImage*

release_appimage:
permissions:
Expand All @@ -56,7 +56,7 @@ jobs:
uses: svenstaro/upload-release-action@v2
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
file: ./Ghostty-x86_64.AppImage*
file: ./Ghostty-*-x86_64.AppImage*
tag: ${{ github.ref }}
overwrite: true
file_glob: true
6 changes: 6 additions & 0 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ EOF

chmod +x AppRun

export VERSION="$(./AppRun --version 2>/dev/null | awk 'FNR==1 {print $2}')"
if [ -z "$VERSION" ]; then
echo "ERROR: Could not get version from ghostty binary"
exit 1
fi

cp "${APPDATA_FILE}" "usr/share/metainfo/com.mitchellh.ghostty.appdata.xml"

# Fix Gnome dock issues -- StartupWMClass attribute needs to be present.
Expand Down