Skip to content

Conversation

@Samueru-sama
Copy link
Member

@Samueru-sama Samueru-sama commented Jan 9, 2025

The current AppImage doesn't work on my Artix linux system since I don't have libonig.so.5, I also don't have GTK4 and a bunch other libraries needed

These changes truly make the appimage work on any linux system, it even runs on the alpine linux container that I have (no glibc).

image

I still have a missing icon on the top left of the screen though 🤔

Please remember to squash and merge to avoid cluttering the commit history with the comments I made lol

@psadi
Copy link
Collaborator

psadi commented Jan 9, 2025

Hey @Samueru-sama - thanks for the suggestions and testing it out. I can confirm the artifact is working as expected.

I truly do agree to add the missing shared object dependencies (only caveat is that AppImage size has been increased from 19M to 52M).

One more thing i noticed is that TERM xterm-ghossty breaks functionality in the AppImage, I think we need to fallback to xterm-256color until the terminfo propagates to dependent systems.

Please let me know if this can be added as well in this PR, i can take it separately otherwise

@psadi psadi added the bug Something isn't working label Jan 9, 2025
@Samueru-sama
Copy link
Member Author

I truly do agree to add the missing shared object dependencies (only caveat is that AppImage size has been increased from 19M to 52M).

Not much can be done, Unfortunately ghost binary has a libicudata.so dependency and that's a 30 MiB lib. (3x bigger than libgtk-4.so).

I noticed zig is being used to build, iirc someone told me that using zig makes it easy to add some libs statically, that should help a ton to reduce the size of the final appimage, for example I maintain an AppImage of mpv (bundle all the libs) and it used to be 80 MiB and then switched to the mpv build script that compiles ffmpeg statically, this reduced the size down to 22 MiB

One more thing i noticed is that TERM xterm-ghossty breaks functionality in the AppImage, I think we need to fallback to xterm-256color until the terminfo propagates to dependent systems.

Please let me know if this can be added as well in this PR, i can take it separately otherwise

You mean this bug wasn't happening before? In any case TERM can be set in the AppRun.

@psadi
Copy link
Collaborator

psadi commented Jan 9, 2025

This was happening before, just that i had noticed this recently. Please feel free too add TERM in AppRun and once default terminfo propagates it can be reverted in the future.

@Samueru-sama
Copy link
Member Author

Btw the libicudata dep comes from libicuuc.so which is dependency libxml2.so which is a dependency of libappstream.so which is a dependency of libadwaita which is needed by the ghostty binary.

It is highly likely that this application at no point makes use of any function provided by libappstream which is just sad, unfortunately this is a common occurrence with gtk apps.

@psadi
Copy link
Collaborator

psadi commented Jan 9, 2025

Thanks for pointing it out, Changes LGTM at the moment!

@psadi psadi merged commit 9df9550 into pkgforge-dev:main Jan 9, 2025
3 checks passed
@Samueru-sama
Copy link
Member Author

Btw the libicudata dep comes from libicuuc.so which is dependency libxml2.so which is a dependency of libappstream.so which is a dependency of libadwaita which is needed by the ghostty binary.

It is highly likely that this application at no point makes use of any function provided by libappstream which is just sad, unfortunately this is a common occurrence with gtk apps.

Btw this isn't a big deal anyway, it turns out that the native ghostty package on Artixlinux uses ~3x more storage because it pulls all of gtk4 and even gstreamer wtf?!

image

psadi pushed a commit that referenced this pull request Jan 18, 2025
psadi pushed a commit that referenced this pull request Jan 18, 2025
psadi pushed a commit that referenced this pull request Jan 18, 2025
ci: ensure release handles multiple arch packages #2
@Samueru-sama Samueru-sama deleted the test branch March 13, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants