fix: build args for stable and nightly builds #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psadi
commented
Feb 18, 2025
| cd "${TMP_DIR}/${BUILD_DIR}" | ||
|
|
||
| sed -i 's/linkSystemLibrary2("bzip2", dynamic_link_opts)/linkSystemLibrary2("bz2", dynamic_link_opts)/' src/build/SharedDeps.zig | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
we needed this when we used ubuntu base image,
Samueru-sama
approved these changes
Feb 18, 2025
| BUILD_ARGS=" | ||
| --summary all \ | ||
| --prefix ${APP_DIR}/usr \ | ||
| -Doptimize=ReleaseFast \ |
Member
There was a problem hiding this comment.
Doesn't changing this to -Drelease-small reduce the size of the binary?
Collaborator
Author
There was a problem hiding this comment.
i tried building with ReleaseFast and ReleaseSmall, reduction in the overall size in 1Meg.
Since the variance is negligible, Lets stick with ReleaseFast which is the preffered arugment per docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.