Switch to uruntime #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closing since the uruntime isn't as much of a drop in replacment with appimagetool as I thought it would. It is still possible to make the AppImage, but that means using mksquashfs manually and also adding llvm-objdump to the CI 😫 |
|
appimagetool should now work with the new version of uruntime |
Collaborator
|
Adding the dep in #49 which would publish a new base This should fix ci issues, please sync once merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default this will try to use FUSE to mount the AppImage, if that fails it will fallback to extract and run, this way the AppImage is guaranteed to always work on any system.
We also get the advantage that the uruntime is slightly faster than the type2 runtime we launched normally with fuse.
NOTE: I cannot get the CI to work because I get this error:
Error: buildx failed with: ERROR: invalid tag "ghcr.io/Samueru-sama/ghostty-appimage:latest": repository name must be lowercase