Skip to content

Conversation

@lwbt
Copy link
Contributor

@lwbt lwbt commented Jan 10, 2025

I see you are using pre-commit. I suggest you add zizmor as another linter for GHA.

Why did you chose to use - id: actionlint-system instead of - id: actionlint?

@psadi
Copy link
Collaborator

psadi commented Jan 10, 2025

Hey @lwbt

I see you are using pre-commit. I suggest you add zizmor as another linter for GHA.

What is the benefit over actionlint? Could you please help to share insights or any documentation ?

Why did you chose to use - id: actionlint-system instead of - id: actionlint?

Reffering docs - i had actionlint installed via homebrew and wanted to use that instead of of the default Go Toolchain installation.

@psadi psadi added the security label Jan 10, 2025
@lwbt
Copy link
Contributor Author

lwbt commented Jan 10, 2025

Hey @lwbt

Why did you chose to use - id: actionlint-system instead of - id: actionlint?

Reffering docs - i had actionlint installed via homebrew and wanted to use that instead of of the default Go Toolchain installation.

I see. However it's a bit counter intuitive when you have to go out and hunt for dependencies instead of letting pre-commit handle it for you. I'm not using homebrew on Linux, but other tools like mise, eget, flatpak and more. It can certainly cover all needs, but it can be overwhelming, which is why I prefer to configure my pre-commit to decouple from the system and manage everything independently.

But it's your choice.

Is anything else required to be able to merge?

@psadi
Copy link
Collaborator

psadi commented Jan 10, 2025

thanks for your insights, PR LGTM!

@psadi
Copy link
Collaborator

psadi commented Jan 10, 2025

There is a later version v0.8.0 available, I will bump to latest version separately.

@psadi psadi merged commit f9de6ea into pkgforge-dev:main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants