-
Notifications
You must be signed in to change notification settings - Fork 7
Detect latest upstream versions #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Detect latest upstream versions - Separate appdata.xml from script code (prepare for multi-arch builds) - Ignore some files
Thanks for this, I also feel that appdata.xml to be automatically generated as part of the build step. We should open a upstream issue/discussion to get more insights. Till then we can maintain it here. |
- Make the code to pick the latest versions require the parameter "latest"
It also means that the AppImage can't be pinned to the dock on xfce4 and kde, I mean you can but the moment you open the app the icon on the dock would duplicate as result. This is an easy fix and I will do it. EDIT: done |
|
Hi @lwbt are we good to merge this? Please let me know if any other works is in progress ? |
It is ready to merge from my point of view. We can remove the custom desktop file as soon as we build a release wich has ghostty-org/ghostty#4930 merged, which should become v1.1.0. |
StartupWMClassin the desktop file no icon would be displayed in Gnome dock or Ubuntu declareStartupWMClassin .desktop ghostty-org/ghostty#4930