Skip to content

Conversation

@lwbt
Copy link
Contributor

@lwbt lwbt commented Jan 10, 2025

lwbt added 6 commits January 10, 2025 20:45
- Detect latest upstream versions
- Separate appdata.xml from script code (prepare for multi-arch builds)
- Ignore some files
@psadi
Copy link
Collaborator

psadi commented Jan 10, 2025

* Separate appdata.xml from script code (prepare for multi-arch builds)

Thanks for this, I also feel that appdata.xml to be automatically generated as part of the build step.

We should open a upstream issue/discussion to get more insights. Till then we can maintain it here.

@Samueru-sama
Copy link
Member

Samueru-sama commented Jan 11, 2025

Without StartupWMClass in the desktop file no icon would be displayed in Gnome dock or Ubuntu

It also means that the AppImage can't be pinned to the dock on xfce4 and kde, I mean you can but the moment you open the app the icon on the dock would duplicate as result.

This is an easy fix and I will do it.

EDIT: done

@psadi
Copy link
Collaborator

psadi commented Jan 11, 2025

Hi @lwbt are we good to merge this?

Please let me know if any other works is in progress ?

@lwbt
Copy link
Contributor Author

lwbt commented Jan 11, 2025

Hi @lwbt are we good to merge this?

Please let me know if any other works is in progress ?

It is ready to merge from my point of view. We can remove the custom desktop file as soon as we build a release wich has ghostty-org/ghostty#4930 merged, which should become v1.1.0.

@psadi psadi merged commit da758c7 into pkgforge-dev:main Jan 11, 2025
3 checks passed
@lwbt lwbt deleted the pr-versions branch January 11, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants