feat: throw when package not in registry

Author: dominykas

lib/loader.js

@@ -14,12 +14,23 @@ const internals = {};
 
 internals.createPackageLoader = async (packageName) => {
 
-    const packument = await Pacote.packument(packageName + '@latest', {
-        'fullMetadata': true,
-        'user-agent': `${Package.name}@${Package.version}, see ${Package.homepage}`
-    });
+    try {
+        const packument = await Pacote.packument(packageName + '@latest', {
+            'fullMetadata': true,
+            'user-agent': `${Package.name}@${Package.version}, see ${Package.homepage}`
+        });
 
-    return internals.createRepositoryLoader(packument.repository.url);
+        return internals.createRepositoryLoader(packument.repository.url);
+    }
+    catch (err) {
+
+        if (err.statusCode === 404) {
+            throw new Error(`Package ${packageName} does not exist`);
+        }
+
+        throw err;
+
+    }
 };
 
 

test/index.js

@@ -498,6 +498,36 @@ describe('node-support', () => {
                     engines: '>=10'
                 });
             });
+
+            it('throws when package does not exist in the registry', async () => {
+
+                Nock('https://registry.npmjs.org')
+                    .get('/node-support')
+                    .reply(404);
+
+                await expect(NodeSupport.detect({ packageName: 'node-support' }))
+                    .to.reject(`Package node-support does not exist`);
+            });
+
+            it('rethrows registry server errors', async () => {
+
+                Nock('https://registry.npmjs.org')
+                    .get('/node-support')
+                    .reply(500);
+
+                await expect(NodeSupport.detect({ packageName: 'node-support' }))
+                    .to.reject(/Internal Server Error/);
+            });
+
+            it('rethrows generic errors', async () => {
+
+                const err = new Error('Something went wrong');
+
+                Sinon.stub(Wreck, 'get').throws(err);
+
+                await expect(NodeSupport.detect({ packageName: 'node-support' }))
+                    .to.reject('Something went wrong');
+            });
         });
     });
 });