refactor: reorganize model imports and create new model files#37
Open
bjohansebas wants to merge 1 commit intopkgjs:mainfrom
Open
refactor: reorganize model imports and create new model files#37bjohansebas wants to merge 1 commit intopkgjs:mainfrom
bjohansebas wants to merge 1 commit intopkgjs:mainfrom
Conversation
wesleytodd
reviewed
Mar 4, 2025
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
I mean, personally I dislike structures like this, they are generally over-engineered and provide little real value. I don't think there is a lot of reuse across files of these so having them in the file where they are used only can help keep things simple.
That said, I am not so strongly opposed that I would block this, it is more of a style/preference thing than a strong technical opposition. Do you feel stronglt that this type of refactor provides some value I am not seeing?
Member
Author
|
It just helps me find those classes more quickly and better separate the objectives of each file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send to new files all the classes that behave as models, which helps improve code readability.