Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #18.
This PR adds a trait,
SnapshotStatistics, and a collection of*StatsSnapshotdata structures which generally mirror the variousStatsdata structures for each reasoner as well as the mainSolverstruct.I chose to define new stat types because the existing
reasoners::*::Stattypes seemed particularly suited to recording statistics, and didn't include all the information printed with theprint_stats()functions. The*StatsSnapshottypes are intended to have a field corresponding to each line fromprint_stats(), and generally be simple, static structures which are easy to export and reason about. These structures also implementserdetraits, when enabled.The trait has a straightforward definition, just returning some structure with a few basic constraints:
Each component implementing
Theorynow implementsSnapshotStatistics, with it's own*StatsSnapshotasStats.As an example (and test) this PR also adds an option to export the
aries-sat's solver stats as JSON.