Skip to content

show warnings if enable/enable_if is called in non-void context #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karupanerura wants to merge 2 commits into
base: master
Choose a base branch
from
Open

show warnings if enable/enable_if is called in non-void context #669

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e29ee6
show warnings if enable/enable_if is called on non-void context
karupanerura Aug 23, 2021
a23f1e5
fix incorrect condition for show the warnings
karupanerura Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Plack/Builder.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,13 @@ sub builder(&) {
$urlmap;
};
local $_add = sub {
defined wantarray
or Carp::carp("WARNING: You used enable() on non-void context");
$self->add_middleware(@_);
};
local $_add_if = sub {
defined wantarray
or Carp::carp("WARNING: You used enable_if() on non-void context");
$self->add_middleware_if(@_);
};

Expand Down