-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add breadcrumb support for crash reporting #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
t-jimbo
wants to merge
9
commits into
main
Choose a base branch
from
feat/breadcrumb-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Breadcrumb struct with message, category, level, data, timestamp - Add recordBreadcrumb and getBreadcrumbs to TrackRepository2 protocol - Implement breadcrumb buffering (max 50 entries) in TrackRespositoryImpl - Include breadcrumbs when sending Flutter crash reports - Add recordBreadcrumb to Container protocol and implementations - Expose recordBreadcrumb via @_spi(FlutterBridge) in NubrickExperiment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
4 tasks
- Add BreadcrumbCategory enum (navigation, ui, http, console, custom) - Add BreadcrumbLevel enum (debug, info, warning, error, fatal) - Update Breadcrumb struct to use enums instead of strings - Add Flutter Bridge compatible recordBreadcrumb overload for string-based data 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Explain expected data structure from Flutter's method channel with inline comments for each type cast. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Change Breadcrumb, BreadcrumbCategory, BreadcrumbLevel to Codable - Persist breadcrumbs to UserDefaults on each record - Load persisted breadcrumbs in processMetricKitCrash - Clear persisted breadcrumbs after loading (one-time use) This enables breadcrumbs to be included in native iOS crash reports delivered by MetricKit in the next app session. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove @_spi(FlutterBridge) from BreadcrumbCategory, BreadcrumbLevel, Breadcrumb - Remove Flutter Bridge recordBreadcrumb(Dictionary) overload - Keep only typed recordBreadcrumb(Breadcrumb) for iOS SDK users Flutter Bridge support will be added in a separate PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- MetricKit crashes: use persisted breadcrumbs (previous session) - Flutter crashes: use in-memory breadcrumbs (same session, immediate send) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add default timestamp to Breadcrumb initializer - Record navigation breadcrumb in trackExperimentEvent - Add doc comment explaining trackExperimentEvent purpose 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Record breadcrumbs when navigating between pages within experiments: - Modal page navigation (with from/to page IDs) - Embedded page navigation (with from/to page IDs) - Tooltip page navigation (with from/to page IDs) - WebView modal page navigation (with from/to page IDs) - Modal/Embedded dismissed (with from page ID) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
t-jimbo
commented
Jan 9, 2026
Collaborator
Author
t-jimbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- currentPageのreset
- .navigation or .ui
- flutterとiosのbreadcrumbsの使い分け
- 非同期処理にする?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breadcrumbstruct with message, category, level, data, timestamprecordBreadcrumb()andgetBreadcrumbs()toTrackRepository2protocolTrackRespositoryImplsendFlutterCrash()recordBreadcrumb()via@_spi(FlutterBridge)inNubrickExperimentUsage (from Flutter Bridge)
Related PRs
Test plan
recordBreadcrumb()stores breadcrumbs correctly🤖 Generated with Claude Code