Closed
Conversation
Contributor
vladavoX
commented
Mar 5, 2026
vladavoX
commented
Mar 5, 2026
vladavoX
commented
Mar 5, 2026
danixeee
reviewed
Mar 5, 2026
5e634b4 to
428e782
Compare
vladavoX
commented
Mar 5, 2026
| } | ||
|
|
||
| function validateFootage(footage: Footage[]) { | ||
| function validateFootage(_: Footage[], missingFootage: MissingFootage[]) { |
Contributor
Author
There was a problem hiding this comment.
its okay to leave it as first unused prop, we will probably need it in future
danixeee
reviewed
Mar 5, 2026
| itemAeFolder: relativePath, | ||
| isMissing: item.footageMissing, | ||
| }); | ||
| if (item.footageMissing || item.file === null) { |
Contributor
There was a problem hiding this comment.
In After Effects ExtendScript, item.file can be null in cases where the FootageItem doesn't have an associated file source, such as:
1. Solids - Color solids created within AE have no file
2. Placeholders - Placeholder footage items
3. Some generated content - Certain procedurally generated footage
The item.footageMissing property is true when the footage was linked to a file but that file can no longer be found on disk.
So the two checks cover different scenarios:
- footageMissing → file was linked but is now missing from disk
- file === null → item never had a file source (solids, placeholders)
Both checks are needed if you want to catch all cases where you can't access actual file data. However, for the purpose of reporting "missing footage" to
users, you might want to distinguish these cases - a solid with file === null isn't really "missing" footage in the traditional sense.
If you only want truly missing footage (files that should exist but don't), item.footageMissing alone might be sufficient. But if file === null items would
cause issues downstream (e.g., when trying to access item.file.fsName), the null check prevents runtime errors.
claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.