Skip to content

fix: Missing footage didn't report error#133

Closed
vladavoX wants to merge 2 commits intomasterfrom
missing-footage-didnt-report-error
Closed

fix: Missing footage didn't report error#133
vladavoX wants to merge 2 commits intomasterfrom
missing-footage-didnt-report-error

Conversation

@vladavoX
Copy link
Contributor

@vladavoX vladavoX commented Mar 5, 2026

image

@vladavoX vladavoX requested a review from danixeee March 5, 2026 09:11
@vladavoX vladavoX force-pushed the missing-footage-didnt-report-error branch from 5e634b4 to 428e782 Compare March 5, 2026 09:42
}

function validateFootage(footage: Footage[]) {
function validateFootage(_: Footage[], missingFootage: MissingFootage[]) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its okay to leave it as first unused prop, we will probably need it in future

@vladavoX vladavoX requested a review from danixeee March 5, 2026 09:59
itemAeFolder: relativePath,
isMissing: item.footageMissing,
});
if (item.footageMissing || item.file === null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In After Effects ExtendScript, item.file can be null in cases where the FootageItem doesn't have an associated file source, such as:                          
                                                                                                                                                                
  1. Solids - Color solids created within AE have no file                                                                                                       
  2. Placeholders - Placeholder footage items                                                                                                                   
  3. Some generated content - Certain procedurally generated footage                                                                                            
                                                                                                                                                                
  The item.footageMissing property is true when the footage was linked to a file but that file can no longer be found on disk.                                  
                                                                                                                                                                
  So the two checks cover different scenarios:                                                                                                                  
  - footageMissing → file was linked but is now missing from disk                                                                                               
  - file === null → item never had a file source (solids, placeholders)                                                                                         
                                                                                                                                                                
  Both checks are needed if you want to catch all cases where you can't access actual file data. However, for the purpose of reporting "missing footage" to     
  users, you might want to distinguish these cases - a solid with file === null isn't really "missing" footage in the traditional sense.                        
                                                                                                                                                                
  If you only want truly missing footage (files that should exist but don't), item.footageMissing alone might be sufficient. But if file === null items would   
  cause issues downstream (e.g., when trying to access item.file.fsName), the null check prevents runtime errors.    

claude

@vladavoX vladavoX closed this Mar 5, 2026
@vladavoX vladavoX deleted the missing-footage-didnt-report-error branch March 5, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants