Version 2.3.6: Use QGIS network stack and improve connectivity handling #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect virbr* bridge interfaces and display their PAC and proxy addresses alongside the primary network address, so users testing from libvirt/virsh VMs can easily configure proxy settings.
Fetch and display the PAC file via localhost (testpac-local) or via the virsh/libvirt bridge network (testpac-vlan) to verify the PAC server is reachable from both the host and VM environments.
Print a reminder about the logs subcommand at the end of the start output so users know how to follow privoxy logs.
Privoxy removes its own pid file on exit, so by the time rm runs the file may already be gone. Use rm -f to avoid the error.
Show a Planet-branded persistent message bar on the QGIS main window when network requests fail, with context-specific messages for proxy errors, timeouts, and general connectivity issues. The bar is automatically dismissed on the first successful request. Uses sip.isdeleted() to guard against the user manually dismissing the widget before the clear callback fires.
Use dict.get() instead of direct key access for the Content-Encoding header, since not all responses include it (e.g. when going through a proxy that decompresses upstream).
Catch all exceptions during login so timeouts, proxy errors, and connection failures don't produce a traceback. The persistent message bar from QGISAdapter already notifies the user, so the login method just silently returns to the login panel.
QGIS uses objectName to identify dock widgets when saving and restoring window state. Setting these now so geometry persistence can be implemented later without changing widget identities.
timlinux
changed the title
Detect SSL/TLS errors in the error message and show a specific message distinguishing proxy-related SSL issues from other SSL failures.
Contributor
Author
|
Release candidate package attached for testing. Install via QGIS Plugin Manager > Install from ZIP. |
Contributor
Author
|
Release candidate package for v2.3.6 testing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
requestssession proxy handling withQgsBlockingNetworkRequestvia a customQGISAdapter, so the plugin respects QGIS proxy settings natively.sip.isdeleted()guard for widget lifecycle safety..get()instead of direct key access to avoidKeyErrorwhen the header is absent.QMainWindow::saveState()to persist dock geometry across sessions.release-3_36from the test matrix.Commits
b243d3euse qgis network stack120543fUpdates to privoxy proxy testing script524fc2aBump version to 2.3.6. Added changelog28c9dd4Dont try to test on 3.36004cd10Add virsh network detection and PAC URLs to privoxy script1813e2aAdd testpac-local and testpac-vlan subcommands to privoxy script61386e6Show log tail hint after privoxy start8776758Fix rm error on privoxy stop when pid file already removedecc8974Add persistent message bar for network connectivity errors385b0bfFix KeyError when Content-Encoding header is absent5e0be2dHandle network errors gracefully during login7cf668cSet objectName on dock widgets for future geometry persistence6ba2addUpdate metadata.txt version to 2.3.62713372Add SSL/TLS error detection to persistent message barTest plan