Support extra flags for mysqld_exporter #629
Conversation
stankevich
force-pushed
the
support-extra-flags-in-mysqld-exporter
branch
from
bc29ff4 to
eac877c
Compare
stankevich
force-pushed
the
support-extra-flags-in-mysqld-exporter
branch
3 times, most recently
from
3f26d14 to
4f78932
Compare
|
Thanks for the helpful pointers, @frouioui! I regenerated the The upgrade test is passing locally, but is failing in CI. Unfortunately, I'm not able to see the reason. I noticed that the post-upgrade |
| verifyDurabilityPolicy "commerce" "semi_sync" | ||
| upgradeToLatest | ||
| verifyVtGateVersion "22.0.0" | ||
| verifyResourceSpec |
There was a problem hiding this comment.
Note to myself: once the next release (v2.15.0) is out, we should do that check before and after we upgrade.
frouioui
left a comment
frouioui
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks for working on that ❤️
These tests are unfortunately pretty flaky indeed 😢 Hopefully we get some time to work on this. |
frouioui
force-pushed
the
support-extra-flags-in-mysqld-exporter
branch
2 times, most recently
from
fdc713e to
4f78932
Compare
|
Merged |
|
Still flaky/failing. I added a retry mechanism to the verify vtgate version function. Hopefully that should help. |
Signed-off-by: Sergey Stankevich <[email protected]>
Signed-off-by: Sergey Stankevich <[email protected]>
Signed-off-by: Sergey Stankevich <[email protected]>
It's possible that mysqldExporter.extraFlags are provided while mysqldExporter.resources are not. Signed-off-by: Sergey Stankevich <[email protected]>
stankevich
force-pushed
the
support-extra-flags-in-mysqld-exporter
branch
3 times, most recently
from
d56e0ac to
30fd381
Compare
Signed-off-by: Sergey Stankevich <[email protected]>
stankevich
force-pushed
the
support-extra-flags-in-mysqld-exporter
branch
from
30fd381 to
9b78217
Compare
|
@frouioui: I rebased this PR and opened a new one in the Vitess repository since the previous one got closed: vitessio/vitess#18364. Thanks! |
|
@frouioui: Can this + vitessio/vitess#18364 be merged, or is there anything else that needs to be done? |
4 participants
Adds a new
mysqldExporter.extraFlagsproperty that can be used to pass custom flags to mysqld_exporter to enable/configure additional collectors. Also, makes it possible to override thecollect.info_schema.tables.databasesvalue if needed. The default behaviour and collector flags remain unchanged.This PR largely follows existing code conventions in the operator. I added a new
FormatArgsConvertBoolean()method to Flags to support mysqld_exporter's flag format. Added the tests for it and for the existingFormatArgs()andMerge()methods.Closes #470.