-
Notifications
You must be signed in to change notification settings - Fork 88
Enable support for v0.15.0 and later mysqld_exporter #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c1a590e to
95e1a40
Compare
Signed-off-by: Matt Lord <[email protected]>
95e1a40 to
e9cf734
Compare
|
@bluecrabs007 am I missing something here? The test updates also pass on |
f02ccfb to
7e36c4d
Compare
Signed-off-by: Matt Lord <[email protected]>
7e36c4d to
657ca0a
Compare
Was the exporter version bumped to 0.18.0? |
Aha! Thanks 😄 |
Signed-off-by: Matt Lord <[email protected]>
c3ca285 to
d110440
Compare
Signed-off-by: Matt Lord <[email protected]>
d110440 to
a74d308
Compare
|
@bluecrabs007 anything else you'd like to see changed or added? Thanks again for all of the help! |
Signed-off-by: Matt Lord <[email protected]>
Thank you! The changes look good.
|
❤️
Yeah, I figured we can leave it in there just to be backwards compatible too. It doesn't hurt anything. |
The operator was stuck on an old version (
v0.14.0) of themysqld_exporterbecause inv0.15.0— which is 2.5 years old now — they removed theDATA_SOURCE_NAMEenvironment variable that the operator used to specify how to connect to themysqldcontainer.When upgrading the
mysqld_exportertov0.18.0on main thevttabletpods fail to come up because of the noted issue:This PR enables support of
v0.15.0and later of themysqld_exporterby using a standard MySQLmy.cnffile which will work with any version of the exporter or any other client more broadly. We also then upgrade the version of themysqld_exporterthat we bundle and test with fromv0.14.0to the latest release:v0.18.0.Fixes: #696