fix(catalog/aws): a Redshift Serverless workgroup lives in its namespace on a diagram; endpoint subnets and endpoint authorizations are access, not placement - #530
Open
avinashsana wants to merge 1 commit into
Conversation
…ace on a diagram -- its subnets and its managed endpoints' subnets are access, not placement, and a Redshift cluster's endpoint authorizations never place it inside the VPCs they admit
Contributor
|
I have read the Planton Contributor License Agreement (CLA.md) and I hereby sign the CLA. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three reference fields on the Redshift kinds become
containment_exempt, so a diagram draws a Redshift Serverless workgroup inside the namespace it serves (reaching into its VPC by lines) and never draws a Redshift cluster inside a VPC it merely authorizes. The containment-decision registry moves exactly those three lines fromcontainedtoexempt; nothing else moves.Context
AwsRedshiftServerlessNamespaceis a container kind. Its workgroup referenced the namespace and three subnets, both as placement -- two rooms that cannot nest, which the doctrine has no honest way to draw (the platform's resolver falls back to topological order and can land the workgroup in a single subnet). The spec already says which room is home: "a workgroup computes; the data it serves lives on the namespace it attaches to." The exemption onAwsRedshiftServerlessWorkgroupSpec.subnet_idsrecords it -- the same verdict the ECS service carries for its subnets while its cluster places it.AwsRedshiftServerlessWorkgroupEndpointAccess.subnet_idsare the consuming VPC's subnets: an access path into the workgroup.AwsRedshiftClusterEndpointAuthorization.vpc_idsadmit another account's VPCs to the cluster; the cluster's ownsubnet_idsstay placement.Changes
catalog/aws/awsredshiftserverlessworkgroup/v1alpha1/spec.proto:containment_exemptonsubnet_idsand onEndpointAccess.subnet_ids, each with its reason in the field comment; regeneratedspec.pb.go.catalog/aws/awsredshiftcluster/v1alpha1/spec.proto:containment_exemptonEndpointAuthorization.vpc_ids; regeneratedspec.pb.go.shared/cloudresourcekind/testdata/containment_decisions.txt: the three verdicts, regenerated with-update._changelog/2026-09/…redshift-serverless-workgroup-lives-in-its-namespace…md.Test plan
go test ./shared/cloudresourcekind/...green; the golden diff is exactly the three lines.buf lint/buf format(viamake protos) clean; Go stubs regenerated. The Java stub compile lane could not run on the authoring machine (no JDK); CI's lane covers it.