Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates support for new Anthropic Claude model variants by adding rate limit entries, adjusting default model selection, and updating token handling.
- Reformats and extends
MODEL_RATE_LIMITSwith new Anthropic Claude models. - Modifies token rate limiting and counting logic to recognize Anthropic providers.
- Changes the default model under AWS to the new Claude-3-5-sonnet-v2 variant.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/coverup/llm.py | Reformatted rate limits dict, added Anthropic model entries, updated token limit/count logic. |
| src/coverup/coverup.py | Updated default_model() to return the new anthropic.claude-3-5-sonnet-20241022-v2:0 for AWS. |
Comments suppressed due to low confidence (1)
src/coverup/llm.py:82
- The
count_tokensfunction lacks a docstring; add one to explain its purpose, parameters, and return value, especially describing how different providers are handled.
def count_tokens(model_name: str, completion: dict):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- removed obsolete assertion;
jaltmayerpizzorno
requested changes
Jun 10, 2025
Collaborator
jaltmayerpizzorno
left a comment
jaltmayerpizzorno
left a comment
There was a problem hiding this comment.
It would be better not to hardcode that string...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.