Fix Windows timer thread shutdown (#991)#1012
Merged
emeryberger merged 1 commit intomasterfrom Mar 4, 2026
Merged
Conversation
Replace time.sleep() with threading.Event.wait() in the Windows timer and memory polling threads so they can be interrupted immediately on shutdown. Previously, stop_timer_thread() would time out after 0.1s because the sleeping thread couldn't check the stop flag, leaving a non-daemon thread alive during interpreter finalization. Fixes #991 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.sleep()withthreading.Event.wait()in Windows timer and memory polling threads sostop_timer_thread()/stop_windows_memory_polling()can interrupt sleeping threads immediatelyFixes the
gilstate_tss_setfatal error reported in #991 — the non-daemon timer thread was surviving pastjoin()timeout and calling into Python during interpreter finalization.Test plan
python3 -m pytest tests/ -v)gilstate_tss_seterrorPythonTracer::stop()warning from PyTorch on shutdown🤖 Generated with Claude Code