feat: remote deployment (full) #343
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ vars: | |
| GOOS: | ||
| sh: go env GOOS | ||
| KUSTOMIZE: "{{.LOCAL_BIN}}/kustomize" | ||
| TEST_TIMEOUT: 15m | ||
| tasks: | ||
| ## Setup | ||
| setup:mockery: | ||
|
|
@@ -71,7 +72,7 @@ tasks: | |
| cmds: | ||
| - | | ||
| export PATH=$(pwd)/{{.LOCAL_BIN}}:$PATH | ||
| go test -timeout {{.TEST_TIMEOUT}} -coverprofile=cover.out github.com/platform-mesh/platform-mesh-operator/test/e2e/kind {{.ADDITIONAL_COMMAND_ARGS}} | ||
|
|
||
|
|
||
| test: | ||
|
|
@@ -82,15 +83,16 @@ tasks: | |
| - cmd: | | ||
| if [ "$GITHUB_WORKFLOW" = "ci" ]; then | ||
| echo "Running tests in Github Actions" | ||
| echo "127.0.0.1 portal.dev.local kcp.api.portal.dev.local" | sudo tee -a /etc/hosts | ||
| PATH=$(pwd)/{{.LOCAL_BIN}}:$PATH go test -timeout {{.TEST_TIMEOUT}} -coverprofile=cover.out ./... {{.ADDITIONAL_COMMAND_ARGS}} || { | ||
| echo "---Listing HelmReleases" | ||
| kubectl get helmreleases -A | ||
| # ... | ||
| exit 1 | ||
| } | ||
| else | ||
| export PATH=$(pwd)/{{.LOCAL_BIN}}:$PATH | ||
| go test -timeout {{.TEST_TIMEOUT}} -coverprofile=cover.out ./... {{.ADDITIONAL_COMMAND_ARGS}} | ||
| fi | ||
| ignore_error: false | ||
|
|
||
|
|
@@ -164,7 +166,6 @@ tasks: | |
| - kubernetes-graphql-gateway | ||
| - openfga | ||
| - observability | ||
| - istiod | ||
| - istio-gateway | ||
| - istio-base | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,27 +23,58 @@ import ( | |
|
|
||
| // PlatformMeshSpec defines the desired state of PlatformMesh | ||
| type PlatformMeshSpec struct { | ||
| Exposure *ExposureConfig `json:"exposure,omitempty"` | ||
| Kcp Kcp `json:"kcp,omitempty"` | ||
| Values apiextensionsv1.JSON `json:"values,omitempty"` | ||
| OCM *OCMConfig `json:"ocm,omitempty"` | ||
| FeatureToggles []FeatureToggle `json:"featureToggles,omitempty"` | ||
| InfraValues apiextensionsv1.JSON `json:"infraValues,omitempty"` | ||
| Wait *WaitConfig `json:"wait,omitempty"` | ||
| ProfileConfigMap *ConfigMapReference `json:"profileConfigMap,omitempty"` | ||
| } | ||
|
|
||
| // ConfigMapReference references a ConfigMap by name and optional namespace. | ||
| // If namespace is not specified, it defaults to the PlatformMesh resource's namespace. | ||
| type ConfigMapReference struct { | ||
| // Name is the name of the ConfigMap. | ||
| // +kubebuilder:validation:MinLength=1 | ||
| Name string `json:"name"` | ||
| // Namespace is the namespace of the ConfigMap. If not specified, defaults to the PlatformMesh resource's namespace. | ||
| // +optional | ||
| Namespace string `json:"namespace,omitempty"` | ||
| } | ||
|
|
||
| type WaitConfig struct { | ||
| ResourceTypes []ResourceType `json:"resourceTypes,omitempty"` // e.g., apps/v1/Deployment, core/v1/ | ||
| } | ||
|
|
||
| type ResourceType struct { | ||
| // Versions are the API versions to check (e.g., ["v1", "v1alpha1"]). | ||
| Versions []string `json:"versions,omitempty"` | ||
| // Group is the API group (e.g., "argoproj.io"). | ||
| Group string `json:"group,omitempty"` | ||
| // Kind is the resource kind (e.g., "Application"). | ||
| Kind string `json:"kind,omitempty"` | ||
| // Name is the specific resource name to check. If empty, uses LabelSelector. | ||
| Name string `json:"name,omitempty"` | ||
| // Namespace is the namespace to search in. | ||
| Namespace string `json:"namespace,omitempty"` | ||
| // LabelSelector filters resources by labels when Name is not specified. | ||
| metav1.LabelSelector `json:",inline,omitempty"` | ||
| // ConditionStatus is the expected condition status (e.g., "True"). | ||
| ConditionStatus metav1.ConditionStatus `json:"conditionStatus,omitempty"` | ||
| // ConditionType is the condition type to check (e.g., "Ready"). | ||
| ConditionType string `json:"conditionType,omitempty"` | ||
| // StatusFieldPath specifies a path to a nested status field to check instead of conditions. | ||
| // When set, StatusValue is required and ConditionType/ConditionStatus are ignored. | ||
| // Example: ["status", "sync", "status"] for ArgoCD Application sync status. | ||
| // +optional | ||
| StatusFieldPath []string `json:"statusFieldPath,omitempty"` | ||
| // StatusValue is the expected value at the StatusFieldPath. | ||
| // Required when StatusFieldPath is set. | ||
| // Example: "Synced" for ArgoCD Application sync status. | ||
| // +optional | ||
| StatusValue string `json:"statusValue,omitempty"` | ||
| } | ||
| type FeatureToggle struct { | ||
| Name string `json:"name,omitempty"` | ||
|
|
@@ -160,15 +191,12 @@ type KcpWorkspace struct { | |
|
|
||
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:subresource:status | ||
| // +kubebuilder:printcolumn:name="DEPLOYMENT",type=string,jsonPath=".status.conditions[?(@.type=='DeploymentSubroutine_Ready')].status",description="Deployment status (shows reason if Unknown)",priority=0 | ||
| // +kubebuilder:printcolumn:name="KCP",type=string,jsonPath=".status.conditions[?(@.type=='KcpsetupSubroutine_Ready')].status",description="KCP status (shows reason if Unknown)",priority=0 | ||
| // +kubebuilder:printcolumn:name="SECRET",type=string,jsonPath=".status.conditions[?(@.type=='ProvidersecretSubroutine_Ready')].status",description="Provider Secret status (shows reason if Unknown)",priority=0 | ||
| // +kubebuilder:printcolumn:name="FEATURES",type=string,jsonPath=".status.conditions[?(@.type=='FeatureToggleSubroutine_Ready')].status",description="Feature toggles' status (shows reason if Unknown)",priority=0 | ||
| // +kubebuilder:printcolumn:name="WAIT",type=string,jsonPath=".status.conditions[?(@.type=='WaitSubroutine_Ready')].status",description="Wait status (shows reason if Unknown)",priority=0 | ||
| // +kubebuilder:printcolumn:name="Ready",type=string,jsonPath=".status.conditions[?(@.type=='Ready')].status",description="Shows if resource is ready",priority=0 | ||
|
|
||
| // PlatformMesh is the Schema for the platform-mesh API | ||
| type PlatformMesh struct { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: platform-mesh/platform-mesh-operator
Length of output: 2145
🌐 Web query:
Docker FROM scratch COPY build context💡 Result:
FROM scratchmeans your final stage starts from an empty image (no shell, no package manager). You typically only useCOPY/ADDplus metadata instructions (likeCMD,ENTRYPOINT,ENV). (docs.docker.com)COPY <src> <dest>can only copy files that are in the build context you pass todocker build(e.g.,docker build .makes.the context).COPY/ADDsource paths are resolved relative to the context root, not relative to where the Dockerfile lives. (docs.docker.com)COPY ../something ...to pull files from outside the build context (it’s blocked for security). (docker.com)Common pattern (multi-stage build): build in one stage, copy into
scratch:This copies from a previous stage (
--from=build), not from your host filesystem. (docs.docker.com)If you truly need files from outside the main context: with BuildKit/buildx you can pass additional named build contexts and then
COPY --from=<name> .... (docker.com)Citations:
Fix COPY instruction: line 37 will fail in
FROM scratchstage without--from=builder.The
COPY --chown=${USER_UID}:${GROUP_UID} gotemplates/ /operator/gotemplatesinstruction cannot access the build context in aFROM scratchstage. Additionally,gotemplates/is not copied into the builder stage, so it is unavailable even with--from=builder.Add
gotemplates/to the builder stage and use--from=builderto copy it into the final image:Required fix
🤖 Prompt for AI Agents