Skip to content

Conversation

@Sobyt483
Copy link
Collaborator

@Sobyt483 Sobyt483 commented Oct 27, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Modified resource ready status display in the list view component to ensure consistent status representation.

@Sobyt483 Sobyt483 requested review from a team as code owners October 27, 2025 13:40
@coderabbitai
Copy link

coderabbitai bot commented Oct 27, 2025

Walkthrough

Replaced dynamic readiness computation in the list view component with a hard-coded ready: true for all mapped resources; several unit tests asserting non-ready behavior were commented out and no longer execute.

Changes

Cohort / File(s) Summary
List view readiness logic
projects/wc/src/app/components/generic-ui/list-view/list-view.component.ts
Removed computed readiness based on resource.status?.conditions and replaced it with hard-coded ready: true in the mapped resource object. The previous conditional logic remains commented out in the diff.
Unit tests (ready status)
projects/wc/src/app/components/generic-ui/list-view/list-view.component.spec.ts
Multiple tests asserting non-ready behavior (False/missing Ready condition, missing status.conditions, mixed statuses) were commented out and are no longer executed; other tests remain unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Areas to review closely:
    • Intent and acceptance criteria for forcing ready: true vs. computing from status.conditions.
    • Tests that were commented out — decide whether to restore, adjust, or remove and update test coverage accordingly.
    • Any UI or downstream consumers that rely on accurate readiness values returned by this mapping.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 7f255cd and 54c52eb.

📒 Files selected for processing (1)
  • projects/wc/src/app/components/generic-ui/list-view/list-view.component.spec.ts (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sobyt483 Sobyt483 enabled auto-merge (squash) October 27, 2025 13:46
@Sobyt483 Sobyt483 self-assigned this Oct 27, 2025
@Sobyt483 Sobyt483 added the bug Something isn't working label Oct 27, 2025
@Sobyt483 Sobyt483 merged commit 783be7b into main Oct 27, 2025
7 checks passed
@Sobyt483 Sobyt483 deleted the stub-ready-check branch October 27, 2025 13:49
Copy link
Contributor

@aaronschweig aaronschweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking for now

@Sobyt483 Sobyt483 linked an issue Oct 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable Ready condition functioanality

4 participants