Merged
Conversation
|
|
mjudeikis
approved these changes
Feb 13, 2026
ntnn
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of https://github.com/platform-mesh/backlog/issues/143
This PR moves the annotation handling into a new
pkg/kubernetes, meant for general basic Kubernetes helpers, and renames the "utils" package to "sync".sync.ConditionTypereads nice for those that import it (I assume this might ultimately be intended for external consumers of this codebase, otherwise I would have made the type private) and the other functions are all related to synchronizing objects between clusters. Moving them into either of the existing packages like "generic" or "broker" would have yielded an import loop.