Prefix provider resource names with hashed consumer cluster name to prevent conflicts#165
Merged
iakmc merged 1 commit intoplatform-mesh:mainfrom Feb 25, 2026
Merged
Conversation
|
|
iakmc
force-pushed
the
consumer-name-prefix
branch
4 times, most recently
from
8326c5f to
748fc02
Compare
iakmc
changed the title
Contributor
Author
|
/test all |
ntnn
reviewed
Feb 18, 2026
examples/certs/run.bash
Outdated
Comment on lines
85
to
93
| kubectl --kubeconfig "$kind_internalca" delete --all --ignore-not-found -n default \ | ||
| certificates.example.platform-mesh.io \ | ||
| certificates.cert-manager.io \ | ||
| secret | ||
|
|
||
| kubectl --kubeconfig "$kind_externalca" delete --all --ignore-not-found -n default \ | ||
| certificates.example.platform-mesh.io \ | ||
| certificates.cert-manager.io \ | ||
| secret |
Member
There was a problem hiding this comment.
Ouh this is dangerous, we shouldn't just delete all secrets.
If someone runs this against a cluster that isn't just for this test that could cause problems :D
Contributor
Author
There was a problem hiding this comment.
In this case, I should fix this https://github.com/platform-mesh/resource-broker/pull/165/changes#diff-bebd4dc669223b64074594f698972d2de4ebb365a3c3da0d534410cea6a2bbc7R147 too
Member
There was a problem hiding this comment.
That would be good, though that one would be fine because it just targets the custom resource and it only displays
iakmc
force-pushed
the
consumer-name-prefix
branch
from
748fc02 to
4abf335
Compare
Contributor
Author
|
/test all |
1 similar comment
Contributor
Author
|
/test all |
iakmc
force-pushed
the
consumer-name-prefix
branch
2 times, most recently
from
4af1ece to
e703e80
Compare
…revent conflicts On-behalf-of: SAP <iskren.pertov@sap.com> Signed-off-by: Iskren Petrov <iskren@kubermatic.com> Prefix provider resource names with hashed consumer cluster name to prevent conflicts fix the tests On-behalf-of: SAP <iskren.pertov@sap.com> Signed-off-by: Iskren Petrov <iskren@kubermatic.com> fix fix edited comment resolved comment fix kcp certs readme and run script On-behalf-of: SAP <iskren.pertov@sap.com> Signed-off-by: Iskren Petrov <iskren@kubermatic.com> fix issues from rebasing On-behalf-of: SAP <iskren.pertov@sap.com> Signed-off-by: Iskren Petrov <iskren@kubermatic.com> fix builds rerun the tests On-behalf-of: SAP <iskren.pertov@sap.com> Signed-off-by: Iskren Petrov <iskren@kubermatic.com> Fix kcp-certs examples test
iakmc
force-pushed
the
consumer-name-prefix
branch
from
fd79f64 to
5df82ee
Compare
ntnn
approved these changes
Feb 24, 2026
ntnn
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.