-
Notifications
You must be signed in to change notification settings - Fork 1
feat: upgrade to the latest version of mcr #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
On-behalf-of: SAP [email protected]
On-behalf-of: SAP [email protected]
On-behalf-of: SAP [email protected]
On-behalf-of: SAP [email protected]
On-behalf-of: SAP [email protected]
aaronschweig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - can you maybe link the PR that changes the kubeconfig generation to point to the workspace and the helm chart changes before merging?
|
I've implemented this solution without changing the operator's kubeconfig, it still points to the virtual workspace host because we need this url for allClient creation and operations across all the involved workspaces. Instead of changing the kubeconfig I've provided a function which creates a config referencing the platform-mesh-system workspace to initialize the apiexport provider. Also after the provider has discovered the apiExportEndpointSlice resource, the kubeconfig becomes useless for the provider and I thought that having virtual workspace url in the kubeconfig would be more convenient for the development because virtual url is very useful If we want to have the original kubeconfig referencing the platform-mesh-system workspace, I could adjust the approach and fetch the apiExportEndpointSlice resource where it's needed |
On-behalf-of: SAP [email protected]
This pr is related to #225
Changes:
apiExportEndpointSliceis locatedapiExportEndpointSliceto discover it dynamicallyAlso, now all mcr providers implement
Runnableinterface and therefore they will run with a manager and there's no need to run them separately