Skip to content

Conversation

@OlegErshov
Copy link
Contributor

@OlegErshov OlegErshov commented Dec 26, 2025

On-behalf-of: SAP [email protected]
This pr is related to #225
Changes:

  1. Upgraded to the latest the mcr version which has a breaking change in the providers setup. Now an apiexport provider requires:
  • kubeconfig which points to the workspace where the apiExportEndpointSlice is located
  • name of the apiExportEndpointSlice to discover it dynamically
    Also, now all mcr providers implement Runnable interface and therefore they will run with a manager and there's no need to run them separately
  1. Refactored kcp api imports to follow the same naming pattern

@github-actions github-actions bot added the fix label Dec 26, 2025
@github-actions github-actions bot added the chore label Dec 26, 2025
@OlegErshov OlegErshov marked this pull request as ready for review December 26, 2025 12:20
@OlegErshov OlegErshov linked an issue Dec 26, 2025 that may be closed by this pull request
@OlegErshov OlegErshov self-assigned this Dec 28, 2025
Copy link
Contributor

@aaronschweig aaronschweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - can you maybe link the PR that changes the kubeconfig generation to point to the workspace and the helm chart changes before merging?

@OlegErshov
Copy link
Contributor Author

I've implemented this solution without changing the operator's kubeconfig, it still points to the virtual workspace host because we need this url for allClient creation and operations across all the involved workspaces. Instead of changing the kubeconfig I've provided a function which creates a config referencing the platform-mesh-system workspace to initialize the apiexport provider. Also after the provider has discovered the apiExportEndpointSlice resource, the kubeconfig becomes useless for the provider and I thought that having virtual workspace url in the kubeconfig would be more convenient for the development because virtual url is very useful

If we want to have the original kubeconfig referencing the platform-mesh-system workspace, I could adjust the approach and fetch the apiExportEndpointSlice resource where it's needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to latest version of MCR and the MCR Provider

3 participants