Skip to content

fix: updated condition on core.platform-mesh.io api export#309

Open
OlegErshov wants to merge 9 commits intomainfrom
fix/platform-mesh.io-apibinding-check
Open

fix: updated condition on core.platform-mesh.io api export#309
OlegErshov wants to merge 9 commits intomainfrom
fix/platform-mesh.io-apibinding-check

Conversation

@OlegErshov
Copy link
Contributor

On-behalf-of: SAP aleh.yarshou@sap.com

On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov OlegErshov self-assigned this Jan 30, 2026
@github-actions github-actions bot added the fix label Jan 30, 2026
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
@github-actions github-actions bot added the chore label Jan 30, 2026
@aaronschweig
Copy link
Contributor

I see this is already quite old - is this still relevant?

@OlegErshov
Copy link
Contributor Author

I think yes, because currently the behavior is a bit inconsistent.

  1. Here in process function we process all ApiBinding resources which are not reference core.platform-mesh.io ApiExport and not kcp related ApiBindings code link
  2. But the same processing check is different for finalizers. In finalizers we currently check if the ApiBinding name has platform-mesh.io or kcp.io in name code link

I think we should set our finalizers only on ApiBindings we process for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants