Handle request serialisation errors asynchronously #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix connection error handling to use callback instead of throwing - Add test for synchronous compression errors in producer - Update connection test to properly handle async error scenarios - Ensure errors are properly propagated through callback mechanism Change-Id: I470ddf3a13871bd68ce92b65fbf24198d844de27
ShogunPanda
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions thrown from the
createPayload()method inconnections.tsare not propagated up the callback hierarchy and hence cannot be handled by a try/catch block around the client method invocation, but end up as uncaught exceptions. This happens e.g. when support for an optional compression scheme likelz4is not actually installed.This change fixes the issue by passing the error to the callback instead of re-throwing it.