Do not deduplicate topic creations and deletions irrespectively of topics #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now creating and deleting multiple topics in a row will ignore most of the topics except the first one. This is due to deduplication that is done based on operation alone without considering the target topics. This change incorporates topic data into the deduplication to avoid the aforementioned issue.
lp247
changed the title
lp247
changed the title
ShogunPanda
requested changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now creating and deleting multiple topics in a row will ignore most of the topics except the first one. This is due to deduplication that is done based on operation alone without considering the target topics. This change incorporates topic data into the deduplication to avoid the aforementioned issue.