Adjust default values for replicas and partitions #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests to create topics will fail if you supply assignments and partitions/replicas together. If you don't supply a value for partitions/replicas at all, default values of 1 will be used which also leads to topic creation failures. Here, the default values for the two settings are changed to -1 so that topic creations do not fail due to conflicting settings. Furthermore, this has the benefit of using the default values set inside the Kafka cluster. Related: - tulios/kafkajs#1305
lp247
force-pushed
the
partitions_replicas_default
branch
from
ed1b731 to
aa6d273
Compare
ShogunPanda
approved these changes
Nov 3, 2025
|
LGTM but CI is failing. Please double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests to create topics will fail if you supply assignments and partitions/replicas together. If you don't supply a value for partitions/replicas at all, default values of 1 will be used which also leads to topic creation failures. Here, the default values for the two settings are changed to -1 so that topic creations do not fail due to conflicting settings. Furthermore, this has the benefit of using the default values set inside the Kafka cluster.
Related: