Skip to content

Commit 006219e

Browse files
committed
fix: run fix-python-soname.js from npm package directory in Linux tests
The fix-python-soname.js script patches the .node file in its __dirname. When run from root, it patches the root .node file (which doesn't exist in Docker tests). We need to run it from the npm package directory to patch the binary that will actually be loaded via pnpm link.
1 parent 593f1e2 commit 006219e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/build-and-test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,8 @@ jobs:
359359
360360
corepack disable
361361
npm i -gf pnpm
362-
node fix-python-soname.js
363362
pnpm install --prefer-offline
364363
pnpm link ./npm/${{ matrix.settings.npm_dir }}
364+
# Run fix-python-soname.js from the npm package directory to patch that binary
365+
node npm/${{ matrix.settings.npm_dir }}/fix-python-soname.js
365366
pnpm test

0 commit comments

Comments
 (0)