Add support for command length limitation on Windows in CheckToolBase#5100
Open
nachomata wants to merge 1 commit intoplatformio:developfrom
Open
Add support for command length limitation on Windows in CheckToolBase#5100nachomata wants to merge 1 commit intoplatformio:developfrom
nachomata wants to merge 1 commit intoplatformio:developfrom
Conversation
Member
|
Hi @nachomata, thanks for the PR. I'm afraid none of our backend tools for static code analysis (cppcheck, clang-tidy) supports response files at the moment. For |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to handle long command lines on Windows by creating a response file when necessary, addressing issue #4446. It is solved by creating a response file when necessary, as suggested here.
Changes made:
platformio/check/tools/base.py: ImportedIS_WINDOWSfromplatformio.compatto check if the operating system is Windows.platformio/check/tools/base.py: Modified theexecute_check_cmdmethod to check if the command length exceeds the Windows limit and create a response file if necessary.platformio/check/tools/base.py: Added the_create_response_filehelper method to generate a temporary response file containing the command arguments.This is just a quick fix addressing the immediate problem. It might need some extra testing and fine-tuning, so any suggestions would be welcome.