Fix: Quote Python path to handle spaces in postinstall scripts#5363
Closed
alex-lisi wants to merge 1 commit intoplatformio:developfrom
Closed
Fix: Quote Python path to handle spaces in postinstall scripts#5363alex-lisi wants to merge 1 commit intoplatformio:developfrom
alex-lisi wants to merge 1 commit intoplatformio:developfrom
Conversation
Wraps Python executable path in quotes when it contains spaces before executing package postinstall scripts. This fixes installation failures on Windows when Python is installed in directories like 'Program Files'. Fixes #5361
Member
|
The recommended way to declare the commdn is LIST type. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes installation failure when Python is installed in a directory containing spaces (e.g.,
C:\Program Files\Python37\).Changes
call_pkg_script()inplatformio/package/manager/base.pyto wrap the Python executable path in quotes when it contains spacesTesting
Related Issue
Fixes #5361