Conversation
|
tjementum
deleted the
pp-1014-stale-frontend-api-client-generation-after-removing-openapi
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fix stale frontend API client generation caused by Turbo not detecting changes to gitignored OpenAPI spec files. After the recent removal of
*.Api.jsonfiles from version control, Turbo's cache no longer detected when the backend regenerated these specs, causingdev:setupandbuildtasks to skip re-runningopenapi-typescript. This resulted in the frontend loading a staleapi.generated.d.tswith missing types and API paths.shared/lib/api/*.Api.jsonas explicit Turbo inputs alongside$TURBO_DEFAULT$for bothbuildanddev:setuptasks, so Turbo includes the gitignored OpenAPI specs in its cache hash and invalidates correctly when the backend regenerates themChecklist