Skip to content

fix: Update EHRBase URL configuration to remove /rest path#29

Merged
platzhersh merged 2 commits intomainfrom
claude/fix-vitals-loading-xpKXZ
Jan 31, 2026
Merged

fix: Update EHRBase URL configuration to remove /rest path#29
platzhersh merged 2 commits intomainfrom
claude/fix-vitals-loading-xpKXZ

Conversation

@platzhersh
Copy link
Owner

@platzhersh platzhersh commented Jan 31, 2026

Summary

Updated the EHRBase URL configuration to remove the /rest path suffix, changing from http://localhost:8080/ehrbase/rest to http://localhost:8080/ehrbase.

Changes

  • Updated .env.example to reflect the new EHRBase URL format
  • Updated api/src/config.py default configuration to match the new URL structure

Details

This change simplifies the EHRBase connection URL by removing the /rest path component. The oehrpy client likely handles the REST API path construction internally, so the base URL should point directly to the EHRBase service root rather than a specific API version path.

This ensures consistency between the example environment configuration and the application's default settings.

https://claude.ai/code/session_01Ekocc3LkbEMZ1DDSVWRQxS

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated the default EHRBase API service endpoint configuration. The base URL path has been revised to reflect API structural updates.

✏️ Tip: You can customize this high-level summary in your review settings.

…n oehrpy requests

The oehrpy SDK appends /rest/ to the base URL internally. With the config
default including /rest, all EHRBase API calls used /ehrbase/rest/rest/...
causing 404 errors for composition creation and AQL queries.

https://claude.ai/code/session_01Ekocc3LkbEMZ1DDSVWRQxS
@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

Walkthrough

The changes update the EHRBase service base URL from http://localhost:8080/ehrbase/rest to http://localhost:8080/ehrbase across configuration and documentation files, removing the "/rest" path segment.

Changes

Cohort / File(s) Summary
Configuration Updates
.env.example, api/src/config.py
Updated EHRBase base URL default value by removing the "/rest" path segment from the endpoint.
Documentation
docs/prd/0005-oehrpy-sdk-integration.md
Updated documentation examples and references to reflect the new EHRBase base URL path without "/rest".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through config files with glee,
Removing "/rest" from each URL we see,
From /ehrbase/rest to /ehrbase so clean,
The simplest refactor this bunny's ever seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title accurately summarizes the main change: removing the /rest path from the EHRBase URL configuration across all affected files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-vitals-loading-xpKXZ

Comment @coderabbitai help to get the list of available commands and usage tips.

@platzhersh platzhersh changed the title Update EHRBase URL configuration to remove /rest path fix: Update EHRBase URL configuration to remove /rest path Jan 31, 2026
@platzhersh platzhersh merged commit 14852e2 into main Jan 31, 2026
2 checks passed
@platzhersh platzhersh deleted the claude/fix-vitals-loading-xpKXZ branch January 31, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments