fix: Update EHRBase URL configuration to remove /rest path#29
Merged
platzhersh merged 2 commits intomainfrom Jan 31, 2026
Merged
fix: Update EHRBase URL configuration to remove /rest path#29platzhersh merged 2 commits intomainfrom
platzhersh merged 2 commits intomainfrom
Conversation
…n oehrpy requests The oehrpy SDK appends /rest/ to the base URL internally. With the config default including /rest, all EHRBase API calls used /ehrbase/rest/rest/... causing 404 errors for composition creation and AQL queries. https://claude.ai/code/session_01Ekocc3LkbEMZ1DDSVWRQxS
WalkthroughThe changes update the EHRBase service base URL from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the EHRBase URL configuration to remove the
/restpath suffix, changing fromhttp://localhost:8080/ehrbase/resttohttp://localhost:8080/ehrbase.Changes
.env.exampleto reflect the new EHRBase URL formatapi/src/config.pydefault configuration to match the new URL structureDetails
This change simplifies the EHRBase connection URL by removing the
/restpath component. The oehrpy client likely handles the REST API path construction internally, so the base URL should point directly to the EHRBase service root rather than a specific API version path.This ensures consistency between the example environment configuration and the application's default settings.
https://claude.ai/code/session_01Ekocc3LkbEMZ1DDSVWRQxS
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.