fix: Add localStorage and sessionStorage to ESLint globals#36
Merged
platzhersh merged 1 commit intomainfrom Jan 31, 2026
Merged
fix: Add localStorage and sessionStorage to ESLint globals#36platzhersh merged 1 commit intomainfrom
platzhersh merged 1 commit intomainfrom
Conversation
Fixes no-undef lint errors for browser storage APIs in both JS/TS and Vue file configurations. https://claude.ai/code/session_01Txu5cvJEDjS6kkbf8HVSad
WalkthroughAdded localStorage and sessionStorage to readonly globals in the ESLint configuration for both JavaScript/TypeScript and Vue file blocks, ensuring these browser APIs are recognized as safe global variables during linting. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated ESLint configuration to recognize
localStorageandsessionStorageas global objects, preventing "undefined variable" linting errors when these Web Storage APIs are used in the codebase.Changes
localStorageandsessionStorageas readonly globals in the browser environment configurationDetails
These Web Storage APIs are standard browser globals and should be recognized by ESLint to avoid false positive linting errors. By marking them as
readonly, we prevent accidental reassignment while allowing their normal usage throughout the application.https://claude.ai/code/session_01Txu5cvJEDjS6kkbf8HVSad
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.