Revenue metrics in APIv2 #4893
Merged
Revenue metrics in APIv2 #4893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
revenue-metrics-apiv2-2
branch
from
c0d9e60 to
41e8233
Compare
RobertJoonas
approved these changes
Dec 11, 2024
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
Looks good to me! 🙌
And thanks for introducing the metric_warnings in this format. I believe we can nicely use that for scroll depth as well when imported data is not being included. :)
macobo
force-pushed
the
revenue-metrics-apiv2-2
branch
from
41e8233 to
a2c5e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR exposes revenue metrics in APIv2 (only on ee).
There are a few scenarios where revenue metrics can't be calculated. On the dashboard we automagically remove these metrics but this isn't a great fit for APIv2. Instead, we return nulls and produce warnings under
response.meta. This is similar to imports where we still return results for the rest of the query.Ref: https://3.basecamp.com/5308029/buckets/39750953/card_tables/cards/8070760266
Docs PR: plausible/docs#571. Will wait for a 👍 from Looker integration before merging.