Expand segments in queries #4982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
saved-segments/expand-segments-in-query
branch
from
1bbe5a9 to
13a843d
Compare
apata
force-pushed
the
saved-segments/expand-segments-in-query
branch
from
13a843d to
c46ac4c
Compare
macobo
reviewed
Jan 16, 2025
apata
commented
Jan 16, 2025
macobo
reviewed
Jan 16, 2025
macobo
reviewed
Jan 16, 2025
macobo
reviewed
Jan 16, 2025
| end | ||
|
|
||
| defp traverse(filters, depth \\ -1) do | ||
| def traverse(filters, depth \\ -1) do |
Contributor
There was a problem hiding this comment.
Annoyingly, usages of this as-is is going to cause annoying conflicts with #4980.
To reduce headaches depending on the order of the merge I suggest copying the implementation from that PR and maybe adding a default to state/state_transformer.
Contributor
Author
There was a problem hiding this comment.
Can we cross that bridge when we come to it?
Contributor
There was a problem hiding this comment.
Yup - just wanted to point out an annoyance you might run into trying to get this merged.
macobo
reviewed
Jan 16, 2025
macobo
reviewed
Jan 16, 2025
apata
force-pushed
the
saved-segments/expand-segments-in-query
branch
from
c78b169 to
d25d088
Compare
macobo
reviewed
Jan 20, 2025
macobo
reviewed
Jan 20, 2025
macobo
reviewed
Jan 20, 2025
macobo
reviewed
Jan 20, 2025
test/plausible_web/controllers/api/external_stats_controller/query_test.exs
Outdated
Show resolved
Hide resolved
macobo
approved these changes
Jan 21, 2025
apata
changed the base branch from
saved-segments/refactor-to-model
to
master
apata
force-pushed
the
saved-segments/expand-segments-in-query
branch
from
72f9a90 to
2cd949b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces functions that handle expanding segments in queries to constituent filters.
Tests
Changelog
Documentation
Dark mode