Refactor: Remove filter_key terminology from backend
#4994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There's two more cases where the word is used, in table_decider_test.exs, lib/plausible/stats/query.ex, but approved. |
apata
approved these changes
Jan 21, 2025
Contributor
Author
|
Thanks. Not sure how I missed table_decider. The query.ex one is related to metrics in honeycomb - given it might break someones dashboard or saved query, don't want to touch it right now. |
macobo
force-pushed
the
filter-key-removal
branch
from
0a7d3c4 to
872967d
Compare
This resurfaced in a recent review, `dimension` or `filter_dimension` is the correct terminology in the backend
macobo
force-pushed
the
filter-key-removal
branch
from
872967d to
2607fa8
Compare
macobo
force-pushed
the
filter-key-removal
branch
from
2607fa8 to
d242573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In a previous PR, using both
dimensionandfilter_keyto refer to filter dimension caused confusion. This PR refactors the code to only refer to dimension or filter_dimension.Depends on #4980