Don't preload goal settings modal to avoid issues with opening in edit mode #5031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
|
Converting this PR back to draft as there's a test failing still. |
zoldar
force-pushed
the
fix-goal-settings-edit-modal-on-first-load
branch
2 times, most recently
from
6de98c8 to
e13783e
Compare
zoldar
force-pushed
the
fix-goal-settings-edit-modal-on-first-load
branch
from
e13783e to
eb2b167
Compare
Contributor
Author
|
It's finally fixed and ready for review. |
aerosol
approved these changes
Jan 30, 2025
RobertJoonas
pushed a commit
that referenced
this pull request
Jan 30, 2025
…t mode (#5031) * Don't preload goal settings modal to avoid issues with opening in edit mode * Remove test which is no longer holding ture * Still enable preload for tests, as it's needed * Fix and move test env switch inside the modal component * Fix for release build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where, on a fresh view load, when trying to open edit dialog for an existing goal, the form is not loaded properly. The preloading optimisation (meant load modal contents in the background in a state defined on page load - in this case, an empty form) breaks it, as first open does not force contents to be reloaded when they should. The modal preopen routine can probably be improved to account for this case with a switch of sorts but currently this is the simplest solution for that particular case.
All the other current uses of the modal component do not have "edit" state currently (Funnel settings still rely on a custom-made solution).