Scroll depth: hide total conversions metric on dashboard #5059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Counting conversions doesn't really make sense in this scenario. If there are multiple goals, nulls are only returned for those affected. If there is at least one scroll goal included by the filter, conversions cannot be counted.
|
|
|
||
| const stats = data && data.top_stats.map(renderStat) | ||
| const stats = | ||
| data && data.top_stats.filter((stat) => stat.value !== null).map(renderStat) |
Contributor
There was a problem hiding this comment.
This will also hide the scroll_depth metric in a page-filtered view, in case there's no engagement data. But I guess showing a - is irrelevant anyway, so I'm still approving this change :)
RobertJoonas
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Counting total conversion events doesn't really make sense in how we store engagement events. After this change this metric is either hidden or displayed as
-when dealing with scroll goals.Tests
Screenshots
Conversions table with scroll goals:
Conversions hidden in top stats when filtering by scroll goal:
No column for total conversions shown when it would be all -
Conversions is not hidden when filtering by other goals:
